Format the repo #18118
Merged
Format the repo #18118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
requested review from
a team,
G4brym,
GregBrimble,
KianNH,
Oxyjun,
WalshyDev,
aninibread,
bjesus,
daisyfaithauma,
elithrar,
haleycode,
irvinebroque,
jonnyparris,
kathayl,
kristianfreeman,
marciocloudflare,
maxvp,
mchenco,
pedrosousa,
sejoker,
simonabadoiu and
thomasgauvin
as code owners
github-actions
bot
assigned
marciocloudflare,
maxvp,
pedrosousa,
WalshyDev,
daisyfaithauma and
G4brym
Contributor
I'm not sure I'm the right person to review this, but I'm finding out who is. |
Contributor
Author
|
rebased. |
KianNH
approved these changes
Nov 15, 2024
Contributor
|
@vicb Kian approved this so it's good to merge when you're ready. |
Contributor
Author
|
Thanks @ToriLindsay and @KianNH 🙏 |
Contributor
|
I had a lot of this in #17262, but looks like this one was merged first. I've updated my PR to reflect this. |
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR formats the repo (
pnpm format).The rationale is that when I create a PR to this repo and want to format the code, I would run
pnpm formatbut because the command fixes all the files in the repo, the PR include will include changes to file I have not updated (that is all the files formatted in this PR).After the PR, running
pnpm formatwill not add noise to PRs.Note: I have added a few exclusions in
.prettierignoreas I don't think it makes sense to format those json files./cc @ToriLindsay